Bug 136308 - WebKit2 swipe gesture should report the position of the snapshot to the client
Summary: WebKit2 swipe gesture should report the position of the snapshot to the client
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-27 14:07 PDT by Tim Horton
Modified: 2014-08-27 18:24 PDT (History)
3 users (show)

See Also:

Attachments
patch (11.20 KB, patch)
2014-08-27 14:09 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-27 14:07:36 PDT 
Add SPI to tell the client where the snapshot is.

rdar://problem/18105827
Comment 1 Tim Horton 2014-08-27 14:09:01 PDT 
Created attachment 237248 [details]
patch
Comment 2 WebKit Commit Bot 2014-08-27 14:11:59 PDT 
Attachment 237248 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.h:112:  The parameter name "layer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-08-27 17:39:27 PDT 
Comment on attachment 237248 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237248&action=review

> Source/WebKit2/UIProcess/PageClient.h:234
> +    virtual CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *) = 0;

const?

> Source/WebKit2/UIProcess/WebPageProxy.h:512
> +    CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *);

const?

> Source/WebKit2/UIProcess/mac/PageClientImpl.h:112
> +    CGRect boundsOfLayerInLayerBackedWindowCoordinates(CALayer *layer);

const?
Comment 4 Tim Horton 2014-08-27 18:24:33 PDT 
http://trac.webkit.org/changeset/173040