Bug 136287 - Take advantage of 3 parameters or32() calls
Summary: Take advantage of 3 parameters or32() calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 06:24 PDT by Julien Brianceau
Modified: 2014-08-27 09:09 PDT (History)
3 users (show)

See Also:

Attachments
Take advantage of 3 parameters or32() calls (5.51 KB, patch)
2014-08-27 06:33 PDT, Julien Brianceau 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2014-08-27 06:24:33 PDT 
For architectures like arm and mips, it's better to use the following sequence:

    or32(op1, op2, dest);

instead of:

    move(op1, dest);
    or32(op2, dest);
Comment 1 Julien Brianceau 2014-08-27 06:33:24 PDT 
Created attachment 237223 [details]
Take advantage of 3 parameters or32() calls
Comment 2 Michael Saboff 2014-08-27 07:46:37 PDT 
Comment on attachment 237223 [details]
Take advantage of 3 parameters or32() calls

r=me
Are you going to look at other logical / arithmetic ops?
Comment 3 Julien Brianceau 2014-08-27 09:06:56 PDT 
Manually committed r173006: http://trac.webkit.org/changeset/173006
Comment 4 Julien Brianceau 2014-08-27 09:09:18 PDT 
(In reply to comment #2)
> Are you going to look at other logical / arithmetic ops?

Yes, but I didn't find other cases yet.