Bug 136286 – [WinCairo] Link error.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

Linking WebKit.dll fails with the following error:

1>MSVCRT.lib(MSVCR120.dll) : error LNK2005: _longjmp already defined in LIBCMT.lib(longjmp.obj) 1>MSVCRT.lib(MSVCR120.dll) : error LNK2005: _modf already defined in LIBCMT.lib(modf_pentium4.obj) Creating library WebKit.lib and object WebKit.exp 1>LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library 1>WebKit.dll : fatal error LNK1169: one or more multiply defined symbols found 1>Done Building Project "WebKit.vcxproj" (Build target(s)) -- FAILED. Build FAILED. Time Elapsed 00:02:01.75

I believe this happens because the WebKit libraries are set up to link statically with the runtime libraries, while the WinCairo libraries are using the dynamic runtime libraries.

Created attachment 237222 [details]
Patch

(In reply to comment #1)
> Created an attachment (id=237222) [details]
> Patch

I'm not sure that this is the right fix; maybe it's better to recompile the WinCairo libraries with static runtime libraries, to avoid differences between AppleWin and WinCairo ...

[Brent Fulgham]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=237222) [details] [details]
> > Patch
> 
> I'm not sure that this is the right fix; maybe it's better to recompile the WinCairo libraries with static runtime libraries, to avoid differences between AppleWin and WinCairo ...

No, your change is correct. I'm intending to switch the Apple build back to DLL's at some point in the near future. Sorry for the inconvenience!

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Created an attachment (id=237222) [details] [details] [details]
> > > Patch
> > 
> > I'm not sure that this is the right fix; maybe it's better to recompile the WinCairo libraries with static runtime libraries, to avoid differences between AppleWin and WinCairo ...
> 
> No, your change is correct. I'm intending to switch the Apple build back to DLL's at some point in the near future. Sorry for the inconvenience!

No worries :)

[WebKit Commit Bot]

Comment on attachment 237222 [details]
Patch

Clearing flags on attachment: 237222

Committed r173013: <http://trac.webkit.org/changeset/173013>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.