Bug 136284 - [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
Summary: [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 03:34 PDT by Rohit
Modified: 2014-09-10 18:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.31 KB, patch)
2014-08-27 03:43 PDT, Rohit
no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2014-08-27 04:04 PDT, Rohit
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rohit 2014-08-27 03:34:27 PDT
Currently tooltip exists only for webpage contents. Add tooltip for toolbar buttons in Minibrowser.
Comment 1 Rohit 2014-08-27 03:43:35 PDT
Created attachment 237216 [details]
Patch
Comment 2 Rohit 2014-08-27 03:49:56 PDT
Currently tooltip is created at (0,0) location on window and displays on button when mouse has any/small movement. This happens because of the way "_elm_tooltip_show" function creates tooltip in EFL. Relevant code snippet from els_tooltip.c file in EFL:

static void
_elm_tooltip_show(Elm_Tooltip *tt)
{
   _elm_tooltip_show_timer_stop(tt);
   _elm_tooltip_hide_anim_stop(tt);

   if (tt->tooltip)
     {
        _elm_tooltip_reconfigure_job_start(tt);
        return;
     }
   if (tt->free_size)
     {
        tt->tt_win = elm_win_add(NULL, "tooltip", ELM_WIN_BASIC);
        elm_win_borderless_set(tt->tt_win, EINA_TRUE);
        elm_win_override_set(tt->tt_win, EINA_TRUE);
        tt->tt_evas = evas_object_evas_get(tt->tt_win);
        tt->tooltip = edje_object_add(tt->tt_evas);
        evas_object_move(tt->tooltip, 0, 0);
        elm_win_resize_object_add(tt->tt_win, tt->tooltip);


If anyone knows any workaround for same, please suggest
Comment 3 Rohit 2014-08-27 04:04:47 PDT
Created attachment 237218 [details]
Patch
Comment 4 Gyuyoung Kim 2014-09-10 17:49:05 PDT
Comment on attachment 237218 [details]
Patch

LGTM. r=me.
Comment 5 WebKit Commit Bot 2014-09-10 18:25:54 PDT
Comment on attachment 237218 [details]
Patch

Clearing flags on attachment: 237218

Committed r173503: <http://trac.webkit.org/changeset/173503>
Comment 6 WebKit Commit Bot 2014-09-10 18:25:59 PDT
All reviewed patches have been landed.  Closing bug.