Write some tests for ScriptSyntaxTree. A good would be to make sure it can parse all statements that we have AST nodes for.
<rdar://problem/18142687>
Created attachment 237279 [details] patch Tests!
Comment on attachment 237279 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237279&action=review Nice! Some suggestions for a few more tests. > LayoutTests/inspector/model/parse-script-syntax-tree.html:203 > + node = makeNode("true;", true); > + InspectorTest.assert(node.type === WebInspector.ScriptSyntaxTree.NodeType.Literal); > + InspectorTest.assert(node.value === true); > + InspectorTest.assert(node.raw === "true"); We might want to also test a few other literals? "null" "/regex/ig" "0x10" "0777" "\"a\"" > LayoutTests/inspector/model/parse-script-syntax-tree.html:276 > + node = makeNode("x = {foo:20};", true); > + InspectorTest.assert(node.right.properties[0].type === WebInspector.ScriptSyntaxTree.NodeType.Property); > + InspectorTest.assert(node.right.properties[0].key); > + InspectorTest.assert(node.right.properties[0].key.type === WebInspector.ScriptSyntaxTree.NodeType.Identifier); > + InspectorTest.assert(node.right.properties[0].value); > + InspectorTest.assert(node.right.properties[0].value.type === WebInspector.ScriptSyntaxTree.NodeType.Literal); > + node = makeNode("x = {'foo':20};", true); > + InspectorTest.assert(node.right.properties[0].key); > + InspectorTest.assert(node.right.properties[0].key.type === WebInspector.ScriptSyntaxTree.NodeType.Literal); > + InspectorTest.log("passed Property"); I'd suggest testing isGetterOrSetter is false here, and testing cases where it is true. "x = {get foo() {return 20}}" "x = {set foo(x) {}}" > LayoutTests/inspector/model/parse-script-syntax-tree.html:327 > + node = makeNode("foo++;", true); > + InspectorTest.assert(node.type === WebInspector.ScriptSyntaxTree.NodeType.UpdateExpression); > + InspectorTest.log("passed UpdateExpression"); Include a test for prefix === false here and a pre-increment/decrement with prefix === true.
Created attachment 237334 [details] patch Made additions Joe suggested
Comment on attachment 237334 [details] patch r=me
Comment on attachment 237334 [details] patch Clearing flags on attachment: 237334 Committed r173103: <http://trac.webkit.org/changeset/173103>
All reviewed patches have been landed. Closing bug.