Bug 136262 – Remove UNUSED_PARAM macros from ServicesOverlayController.mm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dana Burkart]

WebKit2 is failing ASan builds because of two UNUSED_PARAM macros for parameters which no longer exist.

[Dana Burkart]

Created attachment 237163 [details]
Patch to remove the two UNUSED_PARAM() macros

[WebKit Commit Bot]

Attachment 237163 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dana Burkart]

Created attachment 237164 [details]
Patch to remove the two UNUSED_PARAM() macros

Fix style issues in ChangeLog.

[David Kilzer (:ddkilzer)]

Comment on attachment 237163 [details]
Patch to remove the two UNUSED_PARAM() macros

View in context: https://bugs.webkit.org/attachment.cgi?id=237163&action=review

Please post another patch with the UNUSED_PARAM() statements added, and the tab removed from the ChangeLog.  Otherwise, this looks fine.  :)

> Source/WebKit2/ChangeLog:3
> +        The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures.

Maybe say:  "causing ASan build failures."

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394
> -#else
> -    UNUSED_PARAM(rects);

This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point:

    UNUSED_PARAM(rects);
    UNUSED_PARAM(gapRects);
    UNUSED_PARAM(isTextOnly);

[David Kilzer (:ddkilzer)]

Comment on attachment 237164 [details]
Patch to remove the two UNUSED_PARAM() macros

View in context: https://bugs.webkit.org/attachment.cgi?id=237164&action=review

Please fix the UNUSED_PARAM() statements in ServicesOverlayController::selectionRectsDidChange().  Thanks!

> Source/WebKit2/ChangeLog:3
> +        The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures.

Maybe say:  "causing ASan build failures."

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394
> -#else
> -    UNUSED_PARAM(rects);

This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point:

    UNUSED_PARAM(rects);
    UNUSED_PARAM(gapRects);
    UNUSED_PARAM(isTextOnly);

[Dana Burkart]

Created attachment 237165 [details]
Remove one UNUSED_PARAM() call, and add two others.

Changes to address ddkilzer's concerns.

[David Kilzer (:ddkilzer)]

Comment on attachment 237165 [details]
Remove one UNUSED_PARAM() call, and add two others.

r=me

[WebKit Commit Bot]

Comment on attachment 237165 [details]
Remove one UNUSED_PARAM() call, and add two others.

Clearing flags on attachment: 237165

Committed r172974: <http://trac.webkit.org/changeset/172974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.