The snapshot gets stuck if swiping back causes a same document navigation. <rdar://problem/18107826>
Created attachment 237159 [details] patch
Attachment 237159 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237159 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237159&action=review > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:696 > +void PageClientImpl::didSameDocumentNavigationForMainFrame(SameDocumentNavigationType) > +{ > +} > + Why doesn’t this require an iOS implementation? > Source/WebKit2/UIProcess/mac/ViewGestureController.h:31 > #include "WeakObjCPtr.h" > +#include "SameDocumentNavigationType.h" S < W
Comment on attachment 237159 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237159&action=review >> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:696 >> + > > Why doesn’t this require an iOS implementation? iOS's ViewGestureController is a wildly different implementation that takes advantage of UI-side compositing and the transaction system to do this all in a different way. We should converge them eventually, but not today.
http://trac.webkit.org/changeset/172966
(In reply to comment #5) > http://trac.webkit.org/changeset/172966 This broke both the GTK and EFL builds: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/50434/steps/compile-webkit/logs/stdio/text
(In reply to comment #6) > (In reply to comment #5) > > http://trac.webkit.org/changeset/172966 > > This broke both the GTK and EFL builds: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/50434/steps/compile-webkit/logs/stdio/text You guys probably need empty an PageClient override for didSameDocumentNavigationForMainFrame
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > http://trac.webkit.org/changeset/172966 > > > > This broke both the GTK and EFL builds: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/50434/steps/compile-webkit/logs/stdio/text > > You guys probably need empty an PageClient override for didSameDocumentNavigationForMainFrame Fixed the GTK build on http://trac.webkit.org/changeset/172971
EFL fix landed in https://trac.webkit.org/changeset/172972