Bug 136249 - [GTK] Translations are not initialized in the UI process
Summary: [GTK] Translations are not initialized in the UI process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-08-26 04:35 PDT by Carlos Garcia Campos
Modified: 2014-08-26 04:55 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2014-08-26 04:38 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-08-26 04:35:28 PDT 
This is breaking things like webkitContextMenuActionGetForContextMenuItem() for non English locales in the cases where we use the action title to guess the action, because the action title we get from the web process is translated while the one in the UI process is in English. We should initialize gettext also in the Ui process.
Comment 1 Carlos Garcia Campos 2014-08-26 04:38:09 PDT 
Created attachment 237146 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-26 04:39:39 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Philippe Normand 2014-08-26 04:48:33 PDT 
Comment on attachment 237146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237146&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:254
> +    // Initialize gettext here, right before creating the default web context.

Not sure this comment has any relevant info. The explanation in the Changelog would be enough for me :)
Comment 4 Carlos Garcia Campos 2014-08-26 04:55:21 PDT 
Committed r172957: <http://trac.webkit.org/changeset/172957>