Bug 136248 – [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Similar to webkit_uri_request_get_http_headers

[Carlos Garcia Campos]

Created attachment 237142 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Attachment 237142 [details] did not pass style-queue:


WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h"
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:172:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:174:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:175:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Created attachment 237143 [details]
Fix coding style issues

[Sergio Villar Senin]

Comment on attachment 237143 [details]
Fix coding style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=237143&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:280
> +    if (!response->priv->resourceResponse.url().protocolIsInHTTPFamily())

Shouldn't this check be done before the previous one?

[Carlos Garcia Campos]

Comment on attachment 237143 [details]
Fix coding style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=237143&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:280
>> +    if (!response->priv->resourceResponse.url().protocolIsInHTTPFamily())
> 
> Shouldn't this check be done before the previous one?

I don't think so, once we have a valid pointer we should return that one, no need to check again it's an HTTP response

[Gustavo Noronha (kov)]

Comment on attachment 237143 [details]
Fix coding style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=237143&action=review

LGTM

>>> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:280
>>> +    if (!response->priv->resourceResponse.url().protocolIsInHTTPFamily())
>> 
>> Shouldn't this check be done before the previous one?
> 
> I don't think so, once we have a valid pointer we should return that one, no need to check again it's an HTTP response

The detail Sergio may have missed is that httpHeaders is only there if the resposts was for a protocal in the HTTP family. This check protects against creating httpHeaders in the first place (below).

[Carlos Garcia Campos]

Committed r173060: <http://trac.webkit.org/changeset/173060>