Bug 136243 - [iOS WK2] Provide a delegate callback to skip Geolocation authorization per page for WebApp
Summary: [iOS WK2] Provide a delegate callback to skip Geolocation authorization per p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-25 19:21 PDT by Benjamin Poulain
Modified: 2014-08-27 14:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.60 KB, patch)
2014-08-25 19:23 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-08-25 19:21:22 PDT 
[iOS WK2] Provide a delegate callback to skip Geolocation authorization per page for WebApp
Comment 1 Benjamin Poulain 2014-08-25 19:23:32 PDT 
Created attachment 237126 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-25 19:25:45 PDT 
Attachment 237126 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:187:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:188:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2014-08-27 14:50:06 PDT 
Comment on attachment 237126 [details]
Patch

Clearing flags on attachment: 237126

Committed r173019: <http://trac.webkit.org/changeset/173019>
Comment 4 Benjamin Poulain 2014-08-27 14:50:09 PDT 
All reviewed patches have been landed.  Closing bug.