Bug 136239 - Building for native inlining broken on root build
Summary: Building for native inlining broken on root build
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Mirman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-25 16:16 PDT by Matthew Mirman
Modified: 2015-09-24 07:19 PDT (History)
4 users (show)

See Also:

Attachments
Fixes building for native inlining. (45.54 KB, patch)
2014-08-26 13:23 PDT, Matthew Mirman 		no flags Details | Formatted Diff | Diff
Fixes building for native inlining. (45.14 KB, patch)
2014-08-26 13:55 PDT, Matthew Mirman 		fpizlo: review-
fpizlo: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2014-08-25 16:16:24 PDT 
Patch forthcoming.
Comment 1 Matthew Mirman 2014-08-26 13:23:09 PDT 
Created attachment 237170 [details]
Fixes building for native inlining.
Comment 2 Geoffrey Garen 2014-08-26 13:45:41 PDT 
Comment on attachment 237170 [details]
Fixes building for native inlining.

View in context: https://bugs.webkit.org/attachment.cgi?id=237170&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4439
>          if (linkModules(m_ftlState.module, module, LLVMLinkerDestroySource, &outMsg)) {
> -            if (Options::verboseFTLFailure())
> +            // if (verboseCompilationEnabled())

Revert.
Comment 3 Matthew Mirman 2014-08-26 13:55:20 PDT 
Created attachment 237171 [details]
Fixes building for native inlining.

Fixed the commented out code.
Comment 4 Filip Pizlo 2014-08-27 14:11:01 PDT 
Comment on attachment 237171 [details]
Fixes building for native inlining.

I don't think we should make it convention that everything is either exported or ALWAYS_INLINE.  We should have a solution in LLVM that allows us to call static functions from the JIT.
Comment 5 Csaba Osztrogonác 2015-09-14 11:11:10 PDT 
Comment on attachment 237170 [details]
Fixes building for native inlining.

Cleared Geoffrey Garen's review+ from obsolete attachment 237170 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 6 Csaba Osztrogonác 2015-09-24 07:19:23 PDT 
There is no native inlining since https://trac.webkit.org/changeset/187555