RESOLVED FIXED 136237
Make build.webkit.org/dashboard work with changeset_show_files=location 
https://bugs.webkit.org/show_bug.cgi?id=136237
Summary Make build.webkit.org/dashboard work with changeset_show_files=location
Alexey Proskuryakov
Reported 2014-08-25 15:48:07 PDT
trac.webkit.org initialization now contains changeset_show_files=location, which broke Dashboard a little - we now have location information instead of change description in popover.
Attachments
proposed patch (4.57 KB, patch)
2014-08-25 15:55 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-08-25 15:55:59 PDT
Created attachment 237111 [details] proposed patch
Tim Horton
Comment 2 2014-08-25 16:01:59 PDT
Comment on attachment 237111 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=237111&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:106 > + // changes element may or may not be present depending on server configuration (preferably "changeset_show_files=location"); is 'preferably' the right word here? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:137 > + result.tag = location.substr(5, location.indexOf("/", 5) - 5); This is unfortunate but I don't know how to do it better. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:142 > + else if (location.startsWith("trunk/") || location === "trunk") I don't think you need this ===
Alexey Proskuryakov
Comment 3 2014-08-25 16:06:56 PDT
Committed <http://trac.webkit.org/changeset/172941>.
Note You need to log in before you can comment on or make changes to this bug.