Bug 136229 - [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
Summary: [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2014-08-25 11:19 PDT by Brent Fulgham
Modified: 2014-08-25 11:36 PDT (History)
2 users (show)

See Also:

Patch (5.53 KB, patch)
2014-08-25 11:24 PDT, Brent Fulgham
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-08-25 11:19:37 PDT
The "OFFICIAL_BUILD" environment variable is not getting passed down to the Perl scripts that assemble the WebInspectorUI sources into a final minimized document for release builds. This patch corrects this problem.
Comment 1 Brent Fulgham 2014-08-25 11:24:35 PDT
Created attachment 237097 [details]
Comment 2 Brent Fulgham 2014-08-25 11:29:40 PDT
Comment 3 Brent Fulgham 2014-08-25 11:35:53 PDT
Comment on attachment 237097 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=237097&action=review

> Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.pl:83
> +

This is just some drive-by debugging code. I'd like to leave it in so we can see if anything happens in the future.
Comment 4 Brent Fulgham 2014-08-25 11:36:42 PDT
Committed r172929: <http://trac.webkit.org/changeset/172929>