WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136229
[Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
https://bugs.webkit.org/show_bug.cgi?id=136229
Summary
[Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
Brent Fulgham
Reported
2014-08-25 11:19:37 PDT
The "OFFICIAL_BUILD" environment variable is not getting passed down to the Perl scripts that assemble the WebInspectorUI sources into a final minimized document for release builds. This patch corrects this problem.
Attachments
Patch
(5.53 KB, patch)
2014-08-25 11:24 PDT
,
Brent Fulgham
dino
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-08-25 11:24:35 PDT
Created
attachment 237097
[details]
Patch
Brent Fulgham
Comment 2
2014-08-25 11:29:40 PDT
<
rdar://problem/18121645
>
Brent Fulgham
Comment 3
2014-08-25 11:35:53 PDT
Comment on
attachment 237097
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=237097&action=review
> Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.pl:83 > +
This is just some drive-by debugging code. I'd like to leave it in so we can see if anything happens in the future.
Brent Fulgham
Comment 4
2014-08-25 11:36:42 PDT
Committed
r172929
: <
http://trac.webkit.org/changeset/172929
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug