RESOLVED FIXED 136224
[EFL] Share fast/speechsynthesis/ with other ports 
https://bugs.webkit.org/show_bug.cgi?id=136224
Summary [EFL] Share fast/speechsynthesis/ with other ports
Krzysztof Czech
Reported 2014-08-25 06:09:32 PDT
webkit.org/b/136127 introduces platform support for WebSpeech in EFL. I propose to share fast/speechsynthesis tests so that other ports (EFL) could use them. Tests seem to be generic so they do not really need any modifications. I will skip them in other ports, they do not support them yet.
Attachments
patch (deleted)
2014-08-26 07:46 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2014-08-26 07:46:46 PDT
Created attachment 237151 [details] patch
chris fleizach
Comment 2 2014-08-26 10:08:13 PDT
Comment on attachment 237151 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review > Source/cmake/OptionsEfl.cmake:109 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON) it seems like we might want to wait until it's implemented before turning it on or did the implementation already go in?
Krzysztof Czech
Comment 3 2014-08-26 14:13:44 PDT
(In reply to comment #2) > (From update of attachment 237151 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review > > > Source/cmake/OptionsEfl.cmake:109 > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON) > > it seems like we might want to wait until it's implemented before turning it on > or did the implementation already go in? Yes, the implementation is already in (r172956)
WebKit Commit Bot
Comment 4 2014-08-27 01:04:28 PDT
Comment on attachment 237151 [details] patch Clearing flags on attachment: 237151 Committed r173000: <http://trac.webkit.org/changeset/173000>
WebKit Commit Bot
Comment 5 2014-08-27 01:04:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.