webkit.org/b/136127 introduces platform support for WebSpeech in EFL. I propose to share fast/speechsynthesis tests so that other ports (EFL) could use them. Tests seem to be generic so they do not really need any modifications. I will skip them in other ports, they do not support them yet.
Created attachment 237151 [details] patch
Comment on attachment 237151 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review > Source/cmake/OptionsEfl.cmake:109 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON) it seems like we might want to wait until it's implemented before turning it on or did the implementation already go in?
(In reply to comment #2) > (From update of attachment 237151 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review > > > Source/cmake/OptionsEfl.cmake:109 > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON) > > it seems like we might want to wait until it's implemented before turning it on > or did the implementation already go in? Yes, the implementation is already in (r172956)
Comment on attachment 237151 [details] patch Clearing flags on attachment: 237151 Committed r173000: <http://trac.webkit.org/changeset/173000>
All reviewed patches have been landed. Closing bug.