New versions of the spec allow us to set a limit for the size of both implicit and explicit grid.
"Implementations may limit the possible size of the explicit grid. If they do, attempting to specify an explicit grid larger than the implementation-defined maximum must instead define an explicit grid of the maximum size. Implementations may cap the explicit grid to slightly less than the maximum, in order to have only whole repetitions of the repeat() function. It is recommended that the maximum size of the explicit grid not be smaller than 1 million tracks in each axis."
(there is a similar paragraph for the implicit grid).
*** Bug 136944 has been marked as a duplicate of this bug. ***
Created attachment 239410 [details]
Comment on attachment 239410 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=239410&action=review
> +const size_t kGridMaxTracks = 1000000;
Note that the usage of size_t is just for convenience and consistency reasons as the rest of the code is using it. Bug 136218 will replace its usage by unsigned.
Created attachment 239537 [details]
Rebased against latest changes in trunk
Created attachment 239612 [details]
Created attachment 239634 [details]
Created attachment 239718 [details]
Created attachment 239726 [details]
Mac build fixes
It'd be awesome to get a review here since this is blocking some other changes.
Created attachment 240206 [details]
Darin I know you're very busy with tons of other reviews, but it'd be fantastic if you could take a look at this one.
Another ping :)
This patch is almost 1 month old. Would you mind reviewing it please?
Comment on attachment 240206 [details]
r=me. Nice touch converting it to an API test. :)
Committed r175930: <http://trac.webkit.org/changeset/175930>