Bug 13621 - Decompilation of object literal getter incorrectly includes quotes around name
Summary: Decompilation of object literal getter incorrectly includes quotes around name
Status: RESOLVED DUPLICATE of bug 17018
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Keywords: HasReduction
Depends on:
Blocks: 13638
  Show dependency treegraph
Reported: 2007-05-08 00:23 PDT by Jesse Ruderman
Modified: 2008-02-11 17:04 PST (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Ruderman 2007-05-08 00:23:35 PDT
> (function() { return { get x() { } } })

function () 
  return { get "x"()
  } };

The decompilation doesn't compile, so I'm pretty sure it's wrong ;)

Found with jsfunfuzz in a nightly.
Comment 1 Eric Seidel (no email) 2007-05-09 16:59:51 PDT
if I'm understanding this correctly, this is trying to get the property value of the name returned by the function x().  I'm not even sure we support that currently.  A PropertyNode holds a PropertyNameNode and seems to expect that it's an identifier.  I'm guessing this will require more than just serializer changes.
Comment 2 Eric Seidel (no email) 2007-05-09 19:24:03 PDT
I was confused earlier.  The problem currently lies that the PropertyNode::toStream knows if it's streaming a getter/setter, but the PropertyNameNode does not.  The propertyNameNode always adds " " around the name.  Maybe the " " addition should just be pulled out into PropertyNode::streamTo
Comment 3 Jesse Ruderman 2008-02-11 17:04:44 PST

*** This bug has been marked as a duplicate of 17018 ***