Bug 136201 - TypeProfiler search breaks on return statements
Summary: TypeProfiler search breaks on return statements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-24 10:53 PDT by Saam Barati
Modified: 2014-08-25 21:37 PDT (History)
2 users (show)

See Also:


Attachments
patch (5.78 KB, patch)
2014-08-25 10:55 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (5.79 KB, patch)
2014-08-25 20:35 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2014-08-24 10:53:07 PDT
Currently, searching for all TypeLocations in TypeProfiler breaks when looking for an actual return statement in the source text of a function. This breaks because we ask that the search descriptor be a function return statement, but this descriptor should be a function return statement only when we ask for the global return statement of a function (i.e the merged types of all return statements), not when we are asking for the type information for an actual return statement in the source code of a function.

i.e:

function foo() { return bar };

when asking for type information for "return bar", we should not require the search descriptor to be `function return descriptor`.
Comment 1 Saam Barati 2014-08-25 10:55:08 PDT
Created attachment 237094 [details]
patch

Fixes TypeProfiler search.
Comment 2 Saam Barati 2014-08-25 20:35:47 PDT
Created attachment 237130 [details]
patch

Patch can now be applied to ToT
Comment 3 Filip Pizlo 2014-08-25 20:57:27 PDT
Comment on attachment 237130 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2014-08-25 21:36:59 PDT
Comment on attachment 237130 [details]
patch

Clearing flags on attachment: 237130

Committed r172950: <http://trac.webkit.org/changeset/172950>
Comment 5 WebKit Commit Bot 2014-08-25 21:37:02 PDT
All reviewed patches have been landed.  Closing bug.