RESOLVED FIXED 136200
Return statement TypeSet's might be duplicated 
https://bugs.webkit.org/show_bug.cgi?id=136200
Summary Return statement TypeSet's might be duplicated
Saam Barati
Reported 2014-08-24 09:19:08 PDT
Currently, the globalTypeSet which stores the convergence of all types that represent the return type for a function live off CodeBlock. But this is based on a bad assumption that CodeBlock has a one to one mapping with a function in the source code of a program. We want the globalTypeSet of a return statement to live off an object that has a one to one mapping with functions in the source code of a program. Currently, return type sets in CodeBlock that go into the TypeLocation object aren't duplicated because TypeLocationCache will hash cons the TypeSet into the same TypeLocation, but it's still a faulty assumption that should be corrected.
Attachments
patch (5.02 KB, patch)
2014-08-24 16:20 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2014-08-24 16:20:11 PDT
Created attachment 237048 [details] patch Solves the problem by placing the TypeSet on FunctionExecutable.
WebKit Commit Bot
Comment 2 2014-08-25 19:18:16 PDT
Comment on attachment 237048 [details] patch Clearing flags on attachment: 237048 Committed r172949: <http://trac.webkit.org/changeset/172949>
WebKit Commit Bot
Comment 3 2014-08-25 19:18:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.