Bug 136194 - [CMAKE] Build warning by INTERFACE_LINK_LIBRARIES
Summary: [CMAKE] Build warning by INTERFACE_LINK_LIBRARIES
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 140497
  Show dependency treegraph
 
Reported: 2014-08-22 23:17 PDT by Gyuyoung Kim
Modified: 2015-01-15 07:44 PST (History)
9 users (show)

See Also:


Attachments
Patch (5.26 KB, patch)
2014-08-23 22:41 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2014-08-23 22:43 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (5.33 KB, patch)
2014-08-26 19:14 PDT, Gyuyoung Kim
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-08-22 23:17:01 PDT
There has been build warning by INTERFACE_LINK_LIBRARIES.

CMake Warning (dev) in Source/WebKit2/CMakeLists.txt:
  Policy CMP0022 is not set: INTERFACE_LINK_LIBRARIES defines the link
  interface.  Run "cmake --help-policy CMP0022" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  Target "WebKit2" has an INTERFACE_LINK_LIBRARIES property which differs
  from its LINK_INTERFACE_LIBRARIES properties.

  INTERFACE_LINK_LIBRARIES:
Comment 1 Gyuyoung Kim 2014-08-23 22:41:56 PDT
Created attachment 237041 [details]
Patch
Comment 2 Gyuyoung Kim 2014-08-23 22:43:23 PDT
Created attachment 237042 [details]
Patch
Comment 3 Gyuyoung Kim 2014-08-23 22:45:06 PDT
r110024 set the INTERFACE_LINK_LIBRARIES manually because there were build break on major linux distro. However, it was two years ago. It looks we can use it on top level CMakeLists.txt again.
Comment 4 Gyuyoung Kim 2014-08-26 19:14:19 PDT
Created attachment 237193 [details]
Patch
Comment 5 Gyuyoung Kim 2014-09-01 01:23:37 PDT
Anyone take a look this patch ?
Comment 6 Csaba Osztrogonác 2014-09-01 01:47:51 PDT
Comment on attachment 237193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237193&action=review

rs=me

> Source/JavaScriptCore/ChangeLog:8
> +        Set the LINK_INTERFACE_LIBRARIES target property on the tol level CMakeLists.txt.

typo: tol -> top

> Source/WebCore/ChangeLog:8
> +        Set the LINK_INTERFACE_LIBRARIES target property on the top level CMakeLists.txt.

ditto

> Source/WebKit2/ChangeLog:8
> +        Set the LINK_INTERFACE_LIBRARIES target property on the top level CMakeLists.txt.

ditto

> ChangeLog:8
> +        Set the LINK_INTERFACE_LIBRARIES target property on the tol level CMakeLists.txt.

ditto
Comment 7 Csaba Osztrogonác 2014-09-01 01:49:00 PDT
There are only two "tol" typo, not four. :)
Comment 8 Gyuyoung Kim 2014-09-01 02:29:16 PDT
Committed r173155: <http://trac.webkit.org/changeset/173155>
Comment 9 Gyuyoung Kim 2014-09-01 02:30:33 PDT
(In reply to comment #7)
> There are only two "tol" typo, not four. :)

Thanks Ossy ;) Landed after fixing those nits.