RESOLVED FIXED 136194
[CMAKE] Build warning by INTERFACE_LINK_LIBRARIES
https://bugs.webkit.org/show_bug.cgi?id=136194
Summary [CMAKE] Build warning by INTERFACE_LINK_LIBRARIES
Gyuyoung Kim
Reported 2014-08-22 23:17:01 PDT
There has been build warning by INTERFACE_LINK_LIBRARIES. CMake Warning (dev) in Source/WebKit2/CMakeLists.txt: Policy CMP0022 is not set: INTERFACE_LINK_LIBRARIES defines the link interface. Run "cmake --help-policy CMP0022" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "WebKit2" has an INTERFACE_LINK_LIBRARIES property which differs from its LINK_INTERFACE_LIBRARIES properties. INTERFACE_LINK_LIBRARIES:
Attachments
Patch (5.26 KB, patch)
2014-08-23 22:41 PDT, Gyuyoung Kim
no flags
Patch (5.26 KB, patch)
2014-08-23 22:43 PDT, Gyuyoung Kim
no flags
Patch (5.33 KB, patch)
2014-08-26 19:14 PDT, Gyuyoung Kim
ossy: review+
ossy: commit-queue-
Gyuyoung Kim
Comment 1 2014-08-23 22:41:56 PDT
Gyuyoung Kim
Comment 2 2014-08-23 22:43:23 PDT
Gyuyoung Kim
Comment 3 2014-08-23 22:45:06 PDT
r110024 set the INTERFACE_LINK_LIBRARIES manually because there were build break on major linux distro. However, it was two years ago. It looks we can use it on top level CMakeLists.txt again.
Gyuyoung Kim
Comment 4 2014-08-26 19:14:19 PDT
Gyuyoung Kim
Comment 5 2014-09-01 01:23:37 PDT
Anyone take a look this patch ?
Csaba Osztrogonác
Comment 6 2014-09-01 01:47:51 PDT
Comment on attachment 237193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237193&action=review rs=me > Source/JavaScriptCore/ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the tol level CMakeLists.txt. typo: tol -> top > Source/WebCore/ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the top level CMakeLists.txt. ditto > Source/WebKit2/ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the top level CMakeLists.txt. ditto > ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the tol level CMakeLists.txt. ditto
Csaba Osztrogonác
Comment 7 2014-09-01 01:49:00 PDT
There are only two "tol" typo, not four. :)
Gyuyoung Kim
Comment 8 2014-09-01 02:29:16 PDT
Gyuyoung Kim
Comment 9 2014-09-01 02:30:33 PDT
(In reply to comment #7) > There are only two "tol" typo, not four. :) Thanks Ossy ;) Landed after fixing those nits.
Note You need to log in before you can comment on or make changes to this bug.