Bug 136176 - Rubber-banding in overflow:scroll regions does not work correctly with direction:rtl
Summary: Rubber-banding in overflow:scroll regions does not work correctly with direct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-22 15:51 PDT by Beth Dakin
Modified: 2014-08-26 11:30 PDT (History)
8 users (show)

See Also:

Attachments
Test case (457 bytes, text/html)
2014-08-22 15:52 PDT, Beth Dakin 		no flags Details
Patch (1.88 KB, patch)
2014-08-22 16:02 PDT, Beth Dakin 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-08-22 15:51:38 PDT 
Rubber-banding in overflow:scroll regions does not work correctly with direction:rtl
Comment 1 Beth Dakin 2014-08-22 15:52:25 PDT 
Created attachment 237004 [details]
Test case

Test case that shows the bug.
Comment 2 Beth Dakin 2014-08-22 16:02:32 PDT 
Created attachment 237006 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-08-22 16:07:30 PDT 
Comment on attachment 237006 [details]
Patch

no tests?
Comment 4 Beth Dakin 2014-08-22 16:48:55 PDT 
(In reply to comment #3)
> (From update of attachment 237006 [details])
> no tests?

I'm not sure that I can write a test that will actually behave differently with this change, but I will give it a shot.
Comment 5 Beth Dakin 2014-08-25 17:11:03 PDT 
(In reply to comment #3)
> (From update of attachment 237006 [details])
> no tests?

I spent some time today trying to make a test for this, and I still have not figured out how to make a reliable test. The momentum events that Brent added are cool, but they don't seem to be 100% consistent for replicating rubber-banding.
Comment 6 Beth Dakin 2014-08-25 17:13:22 PDT 
http://trac.webkit.org/changeset/172945
Comment 7 Tim Horton 2014-08-25 17:28:41 PDT 
Comment on attachment 237006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237006&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2645
> +    return IntRect(IntPoint(scrollPosition().x(), scrollPosition().y()),

Why not just IntRect(scrollPosition(), ...)? No need for all this fun.
Comment 8 Beth Dakin 2014-08-25 20:31:48 PDT 
(In reply to comment #7)
> (From update of attachment 237006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237006&action=review
> 
> > Source/WebCore/rendering/RenderLayer.cpp:2645
> > +    return IntRect(IntPoint(scrollPosition().x(), scrollPosition().y()),
> 
> Why not just IntRect(scrollPosition(), ...)? No need for all this fun.

r=you to fix, Tim?
Comment 9 Tim Horton 2014-08-25 21:03:52 PDT 
Absolutely!
Comment 10 Beth Dakin 2014-08-26 11:30:14 PDT 
(In reply to comment #9)
> Absolutely!

r172965 :D