Enable WebP support for the WK2 Efl port.
Created attachment 236985 [details] Patch
Created attachment 236986 [details] Patch. Additionally, include libwebp-dev as pre-installed package for WK2 Efl.
Comment on attachment 236986 [details] Patch. Any tests which can be unskipped by this patch ? I just installed libwebp-dev to efl-ews and buildbot. Could you upload a patch again for efl-ews ?
Created attachment 237027 [details] Patch to get re-screening by wk2-efl ews.
(In reply to comment #3) > (From update of attachment 236986 [details]) > Any tests which can be unskipped by this patch ? > Good idea. I will check it soon. :) > I just installed libwebp-dev to efl-ews and buildbot. Could you upload a patch again for efl-ews ? Ok, patch was newly applied.
Comment on attachment 237027 [details] Patch to get re-screening by wk2-efl ews. View in context: https://bugs.webkit.org/attachment.cgi?id=237027&action=review > Source/WTF/wtf/Platform.h:450 > +#if PLATFORM(GTK) || PLATFORM(EFL) If you add this macro, you enable USE(GLIB) as well. It means you enable GTK specific codes as well !! For instance, #if USE(GLIB) typedef struct _GFileIOStream GFileIOStream; typedef struct _GModule GModule; #endif
Created attachment 237028 [details] Patch,
(In reply to comment #6) > (From update of attachment 237027 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237027&action=review > > > Source/WTF/wtf/Platform.h:450 > > +#if PLATFORM(GTK) || PLATFORM(EFL) > > If you add this macro, you enable USE(GLIB) as well. It means you enable GTK specific codes as well !! > > For instance, > > #if USE(GLIB) > typedef struct _GFileIOStream GFileIOStream; > typedef struct _GModule GModule; > #endif Thank you for your correction. :) Patch was newly updated.
Created attachment 239560 [details] Rebased
I just installed libwebp-dev to EFL buildbot and ews. Please upload your patch again for efl ews.
Created attachment 239636 [details] patch rebased.
Can't we unskip below webp tests on EFL port ? # Requires WebP support. Bug(EFL) fast/canvas/canvas-toDataURL-webp.html Bug(EFL) fast/images/webp-image-decoding.html Bug(EFL) fast/images/webp-color-profile-lossless.html Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html Bug(EFL) fast/images/webp-color-profile-lossy.html Bug(EFL) http/tests/images/webp-partial-load.html Bug(EFL) http/tests/images/webp-progressive-load.html
(In reply to comment #12) > Can't we unskip below webp tests on EFL port ? > > # Requires WebP support. > Bug(EFL) fast/canvas/canvas-toDataURL-webp.html > Bug(EFL) fast/images/webp-image-decoding.html > Bug(EFL) fast/images/webp-color-profile-lossless.html > Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html > Bug(EFL) fast/images/webp-color-profile-lossy.html > Bug(EFL) http/tests/images/webp-partial-load.html > Bug(EFL) http/tests/images/webp-progressive-load.html IMO, other test can be enabled except fast/canvas/canvas-toDataURL-webp.html. Canvas test needs investigation. :)
Created attachment 239674 [details] Patch
Created attachment 239676 [details] Patch
Comment on attachment 239676 [details] Patch LGTM
Comment on attachment 239676 [details] Patch Clearing flags on attachment: 239676 Committed r174633: <http://trac.webkit.org/changeset/174633>
All reviewed patches have been landed. Closing bug.
*** Bug 125222 has been marked as a duplicate of this bug. ***