Bug 136151 - [EFL] Unskip compositing test
Summary: [EFL] Unskip compositing test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-22 02:03 PDT by Gyuyoung Kim
Modified: 2014-08-27 00:56 PDT (History)
12 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2014-08-22 02:09 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2014-08-22 20:51 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-08-22 02:03:11 PDT 
SSIA
Comment 1 Gyuyoung Kim 2014-08-22 02:09:54 PDT 
Created attachment 236976 [details]
Patch
Comment 2 Gyuyoung Kim 2014-08-22 20:48:16 PDT 
Comment on attachment 236976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236976&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:-298
> -#if !PLATFORM(IOS) && !PLATFORM(EFL)

After adjust setContentsOpaque() again, almost compositing tests can be passed.

469 tests ran as expected, 51 didn't:


Ryuan, should we keep this macro ?
Comment 3 Gyuyoung Kim 2014-08-22 20:51:02 PDT 
Created attachment 237024 [details]
Patch
Comment 4 Gyuyoung Kim 2014-08-24 21:41:51 PDT 
CC'ing Ossy.
Comment 5 Ryuan Choi 2014-08-24 21:46:00 PDT 
(In reply to comment #3)
> Created an attachment (id=237024) [details]
> Patch

OK.
Looks fine to me.

It was for the transparent webview (ewk_view_bg_color_set).

Unfortunately, WebKitTestRunnder/Efl uses different composting path from general ewk_view.
I agree that skipping composting/ is not for development.

I will keep in mind of this intentional regression for the release until we fix the root cause.
Comment 6 Gyuyoung Kim 2014-08-26 19:55:52 PDT 
Ossy, could you take a look ?
Comment 7 Csaba Osztrogonác 2014-08-27 00:19:30 PDT 
Comment on attachment 237024 [details]
Patch

rs=me
Comment 8 WebKit Commit Bot 2014-08-27 00:56:22 PDT 
Comment on attachment 237024 [details]
Patch

Clearing flags on attachment: 237024

Committed r172999: <http://trac.webkit.org/changeset/172999>
Comment 9 WebKit Commit Bot 2014-08-27 00:56:29 PDT 
All reviewed patches have been landed.  Closing bug.