I'm almost done after this. Just some fine tuning and probably some things I've forgotten.
Created attachment 236960 [details] Patch
Attachment 236960 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/Color.h:59: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/cf/RunLoopObserver.h:41: The parameter name "callback" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:75: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:77: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:78: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:79: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:80: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:81: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:82: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:83: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:86: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:90: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:91: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:92: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/replay/UserInputBridge.h:93: The parameter name "source" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/editing/VisibleSelection.h:90: The parameter name "granularity" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/Scrollbar.h:48: The parameter name "orientation" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/Scrollbar.h:48: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:53: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/ResourceResponseBase.h:59: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceResponseBase.h:62: The parameter name "mimeType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceResponseBase.h:65: The parameter name "expectedContentLength" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceResponseBase.h:68: The parameter name "name" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/editing/VisibleUnits.h:105: The parameter name "position" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/editing/VisibleUnits.h:106: The parameter name "position" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:66: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:71: The parameter name "cachePolicy" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:80: The parameter name "httpMethod" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:122: The parameter name "httpBody" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/cf/ResourceError.h:59: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/editing/SmartReplace.h:36: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/Widget.h:144: The parameter name "view" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/SharedBuffer.h:61: The parameter name "vector" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/SharedBuffer.h:67: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 35 in 183 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236960&action=review > Source/WebCore/page/UserMessageHandlerDescriptor.h:61 > + Noooooo > Source/WebCore/platform/text/TextStream.h:85 > + Noooooooo
http://trac.webkit.org/changeset/172849 broke the Windows build. I'll commit a fix, too.
(In reply to comment #4) > http://trac.webkit.org/changeset/172849 broke the Windows build. I'll commit a fix, too. It looks like you need to define WEBCORE_EXPORT in the WebKit build, or else the WebCore headers it imports will be unusable.
https://trac.webkit.org/r172852 fixed my windows build.
http://trac.webkit.org/changeset/172855 was necessary, too