Bug 136143 - Web Inspector: RetainPtr misuse, CFRunLoopSource leak
Summary: Web Inspector: RetainPtr misuse, CFRunLoopSource leak
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2014-08-21 19:02 PDT by Joseph Pecoraro
Modified: 2014-08-21 20:22 PDT (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (1.73 KB, patch)
2014-08-21 19:03 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-21 19:02:34 PDT
RetainPtr<T>::operator= does a +1. It looks like here there should be an adopt where there isn't:

> Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm:239:5: warning
>     m_runLoopSource = CFRunLoopSourceCreate(nullptr, 1, &runLoopSourceContext);
>     ^
Comment 1 Radar WebKit Bug Importer 2014-08-21 19:02:55 PDT
Comment 2 Joseph Pecoraro 2014-08-21 19:03:47 PDT
Created attachment 236955 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-08-21 20:22:38 PDT
Comment on attachment 236955 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236955

Committed r172845: <http://trac.webkit.org/changeset/172845>
Comment 4 WebKit Commit Bot 2014-08-21 20:22:40 PDT
All reviewed patches have been landed.  Closing bug.