Bug 136139 - Animated GIFs scrolled out of view still cause titlebar blur to update, on tumblr.com page
Summary: Animated GIFs scrolled out of view still cause titlebar blur to update, on tu...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://dedalvs.tumblr.com
Keywords: InRadar
Depends on:
Reported: 2014-08-21 17:40 PDT by Antti Koivisto
Modified: 2014-08-21 22:40 PDT (History)
6 users (show)

See Also:

patch (11.30 KB, patch)
2014-08-21 21:03 PDT, Antti Koivisto
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-08-21 17:40:46 PDT
The code that pauses animations outside the view does not work for subframes.
Comment 1 Antti Koivisto 2014-08-21 17:41:00 PDT
Comment 2 Antti Koivisto 2014-08-21 21:03:15 PDT
Created attachment 236963 [details]
Comment 3 WebKit Commit Bot 2014-08-21 21:06:13 PDT
Attachment 236963 [details] did not pass style-queue:

ERROR: Source/WebKit/mac/WebView/WebView.mm:1576:  The parameter name "view" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/WebCore.exp.in:0:  Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script  [list/order] [5]
Total errors found: 2 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2014-08-21 22:40:00 PDT