RESOLVED FIXED 136133
Add a button to enable paint flashing in the web inspector 
https://bugs.webkit.org/show_bug.cgi?id=136133
Summary Add a button to enable paint flashing in the web inspector
Simon Fraser (smfr)
Reported 2014-08-21 15:27:37 PDT
Add a button to enable paint flashing in the web inspector
Attachments
Patch (6.43 KB, patch)
2014-08-21 15:28 PDT, Simon Fraser (smfr) 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-08-21 15:28:45 PDT
Created attachment 236939 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-08-21 15:29:25 PDT
<rdar://problem/18094974>
Timothy Hatcher
Comment 3 2014-08-21 16:04:30 PDT
Comment on attachment 236939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236939&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:36 > + paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 16, height: 16}; This isn't needed since the two image paths are the same. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:40 > + paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 13, height: 13}; Ditto. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:47 > + this._paintFlashingButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("paint-flashing", WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable paint flashing"), paintFlashingImage.src, paintFlashingImage.width, paintFlashingImage.height); You can use put the image path and size directly here. The width and height should always be 16 to match the SVG.
Simon Fraser (smfr)
Comment 4 2014-08-21 16:49:48 PDT
https://trac.webkit.org/r172839
Note You need to log in before you can comment on or make changes to this bug.