Bug 136133 - Add a button to enable paint flashing in the web inspector
Summary: Add a button to enable paint flashing in the web inspector
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2014-08-21 15:27 PDT by Simon Fraser (smfr)
Modified: 2014-08-21 16:49 PDT (History)
5 users (show)

See Also:

Patch (6.43 KB, patch)
2014-08-21 15:28 PDT, Simon Fraser (smfr)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-08-21 15:27:37 PDT
Add a button to enable paint flashing in the web inspector
Comment 1 Simon Fraser (smfr) 2014-08-21 15:28:45 PDT
Created attachment 236939 [details]
Comment 2 Radar WebKit Bug Importer 2014-08-21 15:29:25 PDT
Comment 3 Timothy Hatcher 2014-08-21 16:04:30 PDT
Comment on attachment 236939 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=236939&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:36
> +        paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 16, height: 16};

This isn't needed since the two image paths are the same.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:40
> +        paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 13, height: 13};


> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:47
> +    this._paintFlashingButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("paint-flashing", WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable paint flashing"), paintFlashingImage.src, paintFlashingImage.width, paintFlashingImage.height);

You can use put the image path and size directly here. The width and height should always be 16 to match the SVG.
Comment 4 Simon Fraser (smfr) 2014-08-21 16:49:48 PDT