RESOLVED FIXED Bug 136130
[GTK] Toggle buttons visually broken with GTK+ 3.13.7 
https://bugs.webkit.org/show_bug.cgi?id=136130
Summary [GTK] Toggle buttons visually broken with GTK+ 3.13.7
Michael Catanzaro
Reported 2014-08-21 12:44:17 PDT
GTK+ 3.13.7 added GTK_STATE_FLAG_CHECKED to solve a theme problem; we have to use it if we want toggle buttons (like checkboxes and radio buttons) to display as active.
Attachments
Patch (1.71 KB, patch)
2014-08-21 13:05 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2014-08-21 12:45:00 PDT
We don't have a see also field? OK, see also: https://bugzilla.gnome.org/show_bug.cgi?id=733967 https://bugzilla.gnome.org/show_bug.cgi?id=735011
Michael Catanzaro
Comment 2 2014-08-21 13:05:09 PDT
Created attachment 236935 [details] Patch
Martin Robinson
Comment 3 2014-08-22 23:33:43 PDT
Comment on attachment 236935 [details] Patch Does GTK_STATE_FLAG_CHECKED exist in older versions as well. Can we just add this flag unconditionally?
Michael Catanzaro
Comment 4 2014-08-23 07:55:46 PDT
No, it's new. If we add it unconditionally then we must bump the GTK+ requirement.
Martin Robinson
Comment 5 2014-08-23 11:11:25 PDT
Comment on attachment 236935 [details] Patch Thanks!
Michael Catanzaro
Comment 6 2014-08-24 09:23:32 PDT
I think this also needs review+ for it to be committed, correct?
Martin Robinson
Comment 7 2014-08-24 14:34:56 PDT
Comment on attachment 236935 [details] Patch Sorry.
WebKit Commit Bot
Comment 8 2014-08-24 15:07:49 PDT
Comment on attachment 236935 [details] Patch Clearing flags on attachment: 236935 Committed r172896: <http://trac.webkit.org/changeset/172896>
WebKit Commit Bot
Comment 9 2014-08-24 15:07:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.