WebResourceLoadScheduler class is a singleton but has public constructor. Access to constructor needs to be changed from public to protected. There is also need to implement a function that is responsible for returning reference to immortal object.
Created attachment 237062 [details] Patch
Comment on attachment 237062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237062&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h:66 > +protected: > + WebResourceLoadScheduler(); > + virtual ~WebResourceLoadScheduler(); Why protected instead of private?
Comment on attachment 237062 [details] Patch This doesn’t seem like a great change. It’s OK, but not a significant improvement.
This patch is a result of discussion from: https://bugs.webkit.org/show_bug.cgi?id=136038
Comment on attachment 237062 [details] Patch This patch is stale and needs to be rebased. The class WebResourceLoadScheduler was renamed to WebLoaderStrategy in <http://trac.webkit.org/changeset/193468> (bug #151854).
Comment on attachment 237062 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.