Bug 136119 - [Mac] WebKit1 plug-in test failures in production builds after r172595
Summary: [Mac] WebKit1 plug-in test failures in production builds after r172595
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
Depends on:
Reported: 2014-08-20 14:04 PDT by Mark Rowe (bdash)
Modified: 2014-08-20 14:43 PDT (History)
1 user (show)

See Also:

Patch (4.32 KB, patch)
2014-08-20 14:09 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-08-20 14:04:58 PDT
WebKit1 Plug-in tests have been failing in production builds since r172595. This is because the script that adds the symlinks from the top level of WebKitLegacy.framework to the Versions/Current directory bails out in production builds. The script also uses the wrong paths by virtue of using CONFIGURATION_BUILD_DIR when it should be using TARGET_BUILD_DIR.
Comment 1 Mark Rowe (bdash) 2014-08-20 14:09:03 PDT
Created attachment 236896 [details]
Comment 2 WebKit Commit Bot 2014-08-20 14:43:48 PDT
Comment on attachment 236896 [details]

Clearing flags on attachment: 236896

Committed r172812: <http://trac.webkit.org/changeset/172812>
Comment 3 WebKit Commit Bot 2014-08-20 14:43:50 PDT
All reviewed patches have been landed.  Closing bug.