RESOLVED FIXED 136106
Enable SATURATED_LAYOUT_ARITHMETIC. 
https://bugs.webkit.org/show_bug.cgi?id=136106
Summary Enable SATURATED_LAYOUT_ARITHMETIC.
zalan
Reported 2014-08-20 10:03:48 PDT
It protects LayoutUnit against arithmetic overflow.
Attachments
Patch (34.23 KB, patch)
2014-08-20 11:22 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (489.65 KB, application/zip)
2014-08-20 14:42 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (542.76 KB, application/zip)
2014-08-20 14:49 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (618.33 KB, application/zip)
2014-08-20 15:44 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (508.79 KB, application/zip)
2014-08-20 16:51 PDT, Build Bot 		no flags
Details
Patch (35.68 KB, patch)
2014-08-21 12:38 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-08-20 11:22:49 PDT
Created attachment 236883 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-20 14:42:20 PDT
Comment on attachment 236883 [details] Patch Rejecting attachment 236883 [details] from commit-queue. New failing tests: fast/ruby/ruby-base-merge-block-children-crash-2.html scrollbars/scrollbar-large-overflow-rectangle.html Full output: http://webkit-queues.appspot.com/results/5981406178050048
WebKit Commit Bot
Comment 3 2014-08-20 14:42:24 PDT
Created attachment 236897 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-08-20 14:49:23 PDT
Comment on attachment 236883 [details] Patch Attachment 236883 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5942739124355072 New failing tests: fast/ruby/ruby-base-merge-block-children-crash-2.html scrollbars/scrollbar-large-overflow-rectangle.html
Build Bot
Comment 5 2014-08-20 14:49:28 PDT
Created attachment 236898 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-08-20 15:44:12 PDT
Comment on attachment 236883 [details] Patch Attachment 236883 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6205562400276480 New failing tests: fast/ruby/ruby-base-merge-block-children-crash-2.html scrollbars/scrollbar-large-overflow-rectangle.html
Build Bot
Comment 7 2014-08-20 15:44:18 PDT
Created attachment 236901 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-08-20 16:51:46 PDT
Comment on attachment 236883 [details] Patch Attachment 236883 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6717072872570880 New failing tests: fast/ruby/ruby-base-merge-block-children-crash-2.html scrollbars/scrollbar-large-overflow-rectangle.html
Build Bot
Comment 9 2014-08-20 16:51:51 PDT
Created attachment 236902 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
zalan
Comment 10 2014-08-21 12:38:42 PDT
Created attachment 236933 [details] Patch
WebKit Commit Bot
Comment 11 2014-08-21 14:34:40 PDT
Comment on attachment 236933 [details] Patch Clearing flags on attachment: 236933 Committed r172835: <http://trac.webkit.org/changeset/172835>
WebKit Commit Bot
Comment 12 2014-08-21 14:34:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.