Bug 136105 - [Win] JavaScriptCore.dll is missing version information
Summary: [Win] JavaScriptCore.dll is missing version information
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Blocker
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2014-08-20 09:26 PDT by Brent Fulgham
Modified: 2014-08-20 12:47 PDT (History)
2 users (show)

See Also:

Patch (1.38 KB, patch)
2014-08-20 10:56 PDT, Brent Fulgham
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-08-20 09:26:32 PDT
The JavaScriptCore.dll is missing the version information specified in the sources. This patch corrects the missing step needed to seed the version resource for the build.
Comment 1 Brent Fulgham 2014-08-20 09:26:52 PDT
Comment 2 Brent Fulgham 2014-08-20 09:31:21 PDT
It looks like the JavaScriptCorePreBuild.cmd is missing a call to auto-version.pl to seed the JSC-specific build directory with the version information.
Comment 3 Brent Fulgham 2014-08-20 10:56:02 PDT
Created attachment 236881 [details]
Comment 4 Brent Fulgham 2014-08-20 12:47:03 PDT
Committed r172805: <http://trac.webkit.org/changeset/172805>