Bug 136095 – [EFL] Apply 'direct' option to accelerated compositing for rendering directly to evas' window.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Hyowon Kim]

Evas introduced EVAS_GL_OPTIONS_DIRECT which allows GL rendering directly to evas' window.
This option would be effective for accelerated compositing on WebKitEFL.

[Hyowon Kim]

Created attachment 236854 [details]
Patch

[Ryuan Choi]

Comment on attachment 236854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236854&action=review

> Source/WebCore/ChangeLog:3
> +        Apply 'direct' option to accelerated compositing for rendering directly to evas' window.

Let's add [EFL] prefix

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:578
> +    return;

Looks unnecessary

[Ryuan Choi]

Comment on attachment 236854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236854&action=review

> Source/WebCore/ChangeLog:18
> +        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
> +        (WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
> +        (WebCore::CoordinatedGraphicsScene::updateViewportFired):
> +        (WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):

I think that you leave the message why you added timer.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:591
> +    else {
> +        if (!m_displayTimer.isActive())
> +            m_displayTimer.startOneShot(0);
> +    }

Let's simply this.

[Ryuan Choi]

hyowon, when you can update this?

[Gyuyoung Kim]

Comment on attachment 236854 [details]
Patch

Cleared review? from attachment 236854 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug or this bug again.

[Ryuan Choi]

Hyowon,

Do you have plan to update this?

If not, I will rebase your patch to land it.

[Ryuan Choi]

Created attachment 255183 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 255183 [details]
Patch

Ryaun, this patch is still valid ?

[Ryuan Choi]

Comment on attachment 255183 [details]
Patch

IMO, this is valid but should be rebased.

So, cleared r? flag.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.