Bug 136095 - [EFL] Apply 'direct' option to accelerated compositing for rendering directly to evas' window.
Summary: [EFL] Apply 'direct' option to accelerated compositing for rendering directly...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Hyowon Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-19 22:42 PDT by Hyowon Kim
Modified: 2017-03-11 10:35 PST (History)
13 users (show)

See Also:


Attachments
Patch (11.25 KB, patch)
2014-08-19 22:52 PDT, Hyowon Kim
no flags Details | Formatted Diff | Diff
Patch (10.08 KB, patch)
2015-06-19 00:28 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hyowon Kim 2014-08-19 22:42:00 PDT
Evas introduced EVAS_GL_OPTIONS_DIRECT which allows GL rendering directly to evas' window.
This option would be effective for accelerated compositing on WebKitEFL.
Comment 1 Hyowon Kim 2014-08-19 22:52:35 PDT
Created attachment 236854 [details]
Patch
Comment 2 Ryuan Choi 2014-08-20 04:52:21 PDT
Comment on attachment 236854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236854&action=review

> Source/WebCore/ChangeLog:3
> +        Apply 'direct' option to accelerated compositing for rendering directly to evas' window.

Let's add [EFL] prefix

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:578
> +    return;

Looks unnecessary
Comment 3 Ryuan Choi 2014-08-20 05:08:24 PDT
Comment on attachment 236854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236854&action=review

> Source/WebCore/ChangeLog:18
> +        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
> +        (WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
> +        (WebCore::CoordinatedGraphicsScene::updateViewportFired):
> +        (WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):

I think that you leave the message why you added timer.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:591
> +    else {
> +        if (!m_displayTimer.isActive())
> +            m_displayTimer.startOneShot(0);
> +    }

Let's simply this.
Comment 4 Ryuan Choi 2014-10-13 04:07:40 PDT
hyowon, when you can update this?
Comment 5 Gyuyoung Kim 2015-02-03 07:37:19 PST
Comment on attachment 236854 [details]
Patch

Cleared review? from attachment 236854 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug or this bug again.
Comment 6 Ryuan Choi 2015-06-18 16:37:07 PDT
Hyowon,

Do you have plan to update this?

If not, I will rebase your patch to land it.
Comment 7 Ryuan Choi 2015-06-19 00:28:02 PDT
Created attachment 255183 [details]
Patch
Comment 8 Gyuyoung Kim 2016-03-09 16:59:16 PST
Comment on attachment 255183 [details]
Patch

Ryaun, this patch is still valid ?
Comment 9 Ryuan Choi 2016-03-09 20:32:20 PST
Comment on attachment 255183 [details]
Patch

IMO, this is valid but should be rebased.

So, cleared r? flag.
Comment 10 Michael Catanzaro 2017-03-11 10:35:32 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.