Bug 136088 - Fix how CodeBlock dumps the opcode op_profile_type
Summary: Fix how CodeBlock dumps the opcode op_profile_type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-19 17:58 PDT by Saam Barati
Modified: 2014-08-20 19:30 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.49 KB, patch)
2014-08-20 18:47 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (1.54 KB, patch)
2014-08-20 18:49 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2014-08-19 17:58:11 PDT 
Currently, the implementation doesn't increment the iterator enough times to go through all arguments.
This never got done when the other patch that incremented the number of arguments the opcode receives was landed.
Comment 1 Saam Barati 2014-08-20 18:47:33 PDT 
Created attachment 236906 [details]
patch

Fixes the bug.
Comment 2 Saam Barati 2014-08-20 18:49:15 PDT 
Created attachment 236907 [details]
patch

Fix problem w/ above patch's ChangeLog incorrect spacing for bug description.
Comment 3 WebKit Commit Bot 2014-08-20 19:30:00 PDT 
Comment on attachment 236907 [details]
patch

Clearing flags on attachment: 236907

Committed r172822: <http://trac.webkit.org/changeset/172822>
Comment 4 WebKit Commit Bot 2014-08-20 19:30:02 PDT 
All reviewed patches have been landed.  Closing bug.