Bug 136084 - Add animationDidEnd callbacks on GraphicsLayer
Summary: Add animationDidEnd callbacks on GraphicsLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-19 15:54 PDT by Simon Fraser (smfr)
Modified: 2014-08-21 15:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (27.65 KB, patch)
2014-08-19 15:56 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (29.74 KB, patch)
2014-08-19 17:29 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-08-19 15:54:23 PDT 
Add animationDidEnd callbacks on GraphicsLayer
Comment 1 Simon Fraser (smfr) 2014-08-19 15:56:50 PDT 
Created attachment 236830 [details]
Patch
Comment 2 Tim Horton 2014-08-19 16:01:13 PDT 
Comment on attachment 236830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236830&action=review

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:352
> +void PlatformCALayerMac::animationStarted(const String& animtionKey, CFTimeInterval beginTime)

anim*a*tion

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:137
> +    auto it = m_layersWithAnimations.find(layerID);

should we not remove the layer from m_layersWithAnimations if it doesn't have any more animations?
Comment 3 Simon Fraser (smfr) 2014-08-19 17:29:51 PDT 
Created attachment 236837 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-08-21 15:44:08 PDT 
https://trac.webkit.org/r172836