Bug 136083 - Fix indentation and style in LowLevelInterpreter.asm
Summary: Fix indentation and style in LowLevelInterpreter.asm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-19 15:10 PDT by Filip Pizlo
Modified: 2014-08-19 15:26 PDT (History)
9 users (show)

See Also:

Attachments
the patch (10.24 KB, patch)
2014-08-19 15:12 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-08-19 15:10:30 PDT 
If/then/else statements in offlineasm are not preprocessor macros.  Their contents should be indented appropriately.  Also "not" is a thing so there is no need to do weird things like "if <blah>\nelse" when you could do "if not <blah>".
Comment 1 Mark Lam 2014-08-19 15:11:44 PDT 
(In reply to comment #0)
> Also "not" is a thing so there is no need to do weird things like "if <blah>\nelse" when you could do "if not <blah>".

Nice.  I didn’t know about that.
Comment 2 Filip Pizlo 2014-08-19 15:12:22 PDT 
Created attachment 236827 [details]
the patch
Comment 3 Mark Lam 2014-08-19 15:14:36 PDT 
Comment on attachment 236827 [details]
the patch

r=me
Comment 4 Filip Pizlo 2014-08-19 15:26:04 PDT 
Landed in http://trac.webkit.org/changeset/172767