WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136068
JSC_timeout is hard-coded in run-javascriptcore-test
https://bugs.webkit.org/show_bug.cgi?id=136068
Summary
JSC_timeout is hard-coded in run-javascriptcore-test
Akos Kiss
Reported
2014-08-19 04:31:29 PDT
Currently, the value of the JSC_timeout environment variable is unconditionally set to 60 (seconds). On some platforms, that's overly restrictive since the running time of some jsc tests can exceed 60 seconds (not because of hanging, just running slowly). The caller of run-javascriptcore-tests should be able to increase/set this timeout value to get valid results.
Attachments
Proposed patch.
(1.66 KB, patch)
2014-08-19 04:38 PDT
,
Akos Kiss
no flags
Details
Formatted Diff
Diff
Proposed patch, v2
(1.26 KB, patch)
2014-08-19 05:30 PDT
,
Akos Kiss
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Akos Kiss
Comment 1
2014-08-19 04:38:55 PDT
Created
attachment 236808
[details]
Proposed patch. This patch allows changing the timeout for jsc tests by defining JSC_timeout in advance, e.g., as follows: JSC_timeout=120 Tools/Scripts/run-javascriptcore-tests
Csaba Osztrogonác
Comment 2
2014-08-19 04:53:41 PDT
Comment on
attachment 236808
[details]
Proposed patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=236808&action=review
> Tools/Scripts/run-javascriptcore-tests:151 > +$ENV{JSC_timeout} = 60 if (!defined($ENV{JSC_timeout})); # Set a 60 second timeout on all jsc tests (if environment variable not defined already).
I think we can do it in a simpler way: $ENV{JSC_timeout} = 60 unless $ENV{JSC_timeout};
Akos Kiss
Comment 3
2014-08-19 05:30:01 PDT
Created
attachment 236810
[details]
Proposed patch, v2 Made the change more perlish, according to the review.
Csaba Osztrogonác
Comment 4
2014-08-19 05:30:57 PDT
Comment on
attachment 236810
[details]
Proposed patch, v2 LGTM
WebKit Commit Bot
Comment 5
2014-08-19 06:09:40 PDT
Comment on
attachment 236810
[details]
Proposed patch, v2 Clearing flags on attachment: 236810 Committed
r172751
: <
http://trac.webkit.org/changeset/172751
>
WebKit Commit Bot
Comment 6
2014-08-19 06:09:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug