Bug 136052 - Stop using pseudo-aware traversal in RenderListItem
Summary: Stop using pseudo-aware traversal in RenderListItem
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 16:51 PDT by Antti Koivisto
Modified: 2014-08-18 17:50 PDT (History)
4 users (show)

See Also:

Attachments
patch (5.98 KB, patch)
2014-08-18 16:58 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-08-18 16:51:14 PDT 
Normal traversal works fine.
Comment 1 Antti Koivisto 2014-08-18 16:58:01 PDT 
Created attachment 236790 [details]
patch
Comment 2 Darin Adler 2014-08-18 17:15:33 PDT 
Comment on attachment 236790 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236790&action=review

> Source/WebCore/rendering/RenderListItem.cpp:-138
> -        // FIXME: Can this be optimized to skip the children of the elements without a renderer?

So I guess you are removing this because the answer is no?
Comment 3 Antti Koivisto 2014-08-18 17:34:00 PDT 
> > -        // FIXME: Can this be optimized to skip the children of the elements without a renderer?
> 
> So I guess you are removing this because the answer is no?

It could, it just didn't feel important enough for a FIXME.

We should really have abstraction for "traverse render tree in DOM order" which would do optimisations like that.
Comment 4 Antti Koivisto 2014-08-18 17:50:35 PDT 
This is actually wrong, a pseudo element can have display:list-item.