RESOLVED FIXED 136048
Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture 
https://bugs.webkit.org/show_bug.cgi?id=136048
Summary Expose long mouse press WebKit API. Part of 135257 - Add long mouse press ges...
Peyton Randolph
Reported 2014-08-18 13:47:42 PDT
It would be convenient to have callbacks in the injected bundle and client for the long mouse press gesture.
Attachments
Patch (35.96 KB, patch)
2014-08-18 13:57 PDT, Peyton Randolph 		no flags
DetailsFormatted DiffDiff
Patch (35.97 KB, patch)
2014-08-18 14:21 PDT, Peyton Randolph 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peyton Randolph
Comment 1 2014-08-18 13:57:22 PDT
Created attachment 236782 [details] Patch
mitz
Comment 2 2014-08-18 14:09:53 PDT
Comment on attachment 236782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171 > + WKBundlePageDidBeginTrackingPotentialLongMousePressCallback didBeginTrackingPotentialLongMousePress; > + WKBundlePageDidRecognizeLongMousePressCallback didRecognizeLongMousePress; > + WKBundlePageDidCancelTrackingPotentialLongMousePressCallback didCancelTrackingPotentialLongMousePress; These last three aren’t aligned with all of the above. > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209 > + WKTypeRef userDataToPass = 0; Please use nullptr. > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219 > + WKTypeRef userDataToPass = 0; Ditto. > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229 > + WKTypeRef userDataToPass = 0; Ditto.
Peyton Randolph
Comment 3 2014-08-18 14:21:01 PDT
(In reply to comment #2) > (From update of attachment 236782 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171 > > + WKBundlePageDidBeginTrackingPotentialLongMousePressCallback didBeginTrackingPotentialLongMousePress; > > + WKBundlePageDidRecognizeLongMousePressCallback didRecognizeLongMousePress; > > + WKBundlePageDidCancelTrackingPotentialLongMousePressCallback didCancelTrackingPotentialLongMousePress; > > These last three aren’t aligned with all of the above. Aligned. > > > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209 > > + WKTypeRef userDataToPass = 0; > > Please use nullptr. Fixed. > > > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219 > > + WKTypeRef userDataToPass = 0; > > Ditto. Fixed. > > > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229 > > + WKTypeRef userDataToPass = 0; > > Ditto. Fixed.
Peyton Randolph
Comment 4 2014-08-18 14:21:41 PDT
Created attachment 236784 [details] Patch
WebKit Commit Bot
Comment 5 2014-08-18 15:03:40 PDT
Comment on attachment 236784 [details] Patch Clearing flags on attachment: 236784 Committed r172729: <http://trac.webkit.org/changeset/172729>
WebKit Commit Bot
Comment 6 2014-08-18 15:03:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.