Bug 136048 - Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture
Summary: Expose long mouse press WebKit API. Part of 135257 - Add long mouse press ges...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 13:47 PDT by Peyton Randolph
Modified: 2014-08-18 15:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch (35.96 KB, patch)
2014-08-18 13:57 PDT, Peyton Randolph 		no flags Details | Formatted Diff | Diff
Patch (35.97 KB, patch)
2014-08-18 14:21 PDT, Peyton Randolph 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peyton Randolph 2014-08-18 13:47:42 PDT 
It would be convenient to have callbacks in the injected bundle and client for the long mouse press gesture.
Comment 1 Peyton Randolph 2014-08-18 13:57:22 PDT 
Created attachment 236782 [details]
Patch
Comment 2 mitz 2014-08-18 14:09:53 PDT 
Comment on attachment 236782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback            didBeginTrackingPotentialLongMousePress;
> +    WKBundlePageDidRecognizeLongMousePressCallback                         didRecognizeLongMousePress;
> +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback           didCancelTrackingPotentialLongMousePress;

These last three aren’t aligned with all of the above.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> +    WKTypeRef userDataToPass = 0;

Please use nullptr.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> +    WKTypeRef userDataToPass = 0;

Ditto.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> +    WKTypeRef userDataToPass = 0;

Ditto.
Comment 3 Peyton Randolph 2014-08-18 14:21:01 PDT 
(In reply to comment #2)
> (From update of attachment 236782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> > +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback            didBeginTrackingPotentialLongMousePress;
> > +    WKBundlePageDidRecognizeLongMousePressCallback                         didRecognizeLongMousePress;
> > +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback           didCancelTrackingPotentialLongMousePress;
> 
> These last three aren’t aligned with all of the above.

Aligned.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> > +    WKTypeRef userDataToPass = 0;
> 
> Please use nullptr.

Fixed.

> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> > +    WKTypeRef userDataToPass = 0;
> 
> Ditto.

Fixed.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> > +    WKTypeRef userDataToPass = 0;
> 
> Ditto.

Fixed.
Comment 4 Peyton Randolph 2014-08-18 14:21:41 PDT 
Created attachment 236784 [details]
Patch
Comment 5 WebKit Commit Bot 2014-08-18 15:03:40 PDT 
Comment on attachment 236784 [details]
Patch

Clearing flags on attachment: 236784

Committed r172729: <http://trac.webkit.org/changeset/172729>
Comment 6 WebKit Commit Bot 2014-08-18 15:03:43 PDT 
All reviewed patches have been landed.  Closing bug.