Bug 136042 - [GTK] when running with WEBKIT_OUTPUTDIR the configuration is ignored
Summary: [GTK] when running with WEBKIT_OUTPUTDIR the configuration is ignored
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Víctor M. Jáquez L.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 10:04 PDT by Víctor M. Jáquez L.
Modified: 2014-08-19 02:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2014-08-18 10:13 PDT, Víctor M. Jáquez L. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor M. Jáquez L. 2014-08-18 10:04:13 PDT 
When executing run-launcher or run-webkit-tests with WEBKIT_OUTPUTDIR set, the configuration flag (--debug/--release) is ignored.
Comment 1 Víctor M. Jáquez L. 2014-08-18 10:13:06 PDT 
Created attachment 236766 [details]
Patch
Comment 2 Martin Robinson 2014-08-18 10:16:25 PDT 
Comment on attachment 236766 [details]
Patch

It seems pretty likely this is going to break a lot of scripts which just look for built products in WEBKIT_OUTPUTDIR.
Comment 3 Víctor M. Jáquez L. 2014-08-18 10:44:23 PDT 
oops! It breaks the bot compilation.
Comment 4 Víctor M. Jáquez L. 2014-08-18 10:55:20 PDT 
Is there a way to see CMakeOutput.log nad CMakeError.log?
Comment 5 Víctor M. Jáquez L. 2014-08-18 11:36:37 PDT 
I've found why

# [Gtk] We don't have Release/Debug configurations in straight
# autotool builds (non build-webkit). In this case and if
# WEBKIT_OUTPUTDIR exist, use that as our configuration dir. This will
# allows us to run run-webkit-tests without using build-webkit

Perhaps we should change that with cmake.  But I'm not sure. Resolving as invalid.
Comment 6 Philippe Normand 2014-08-19 02:15:11 PDT 
Comment on attachment 236766 [details]
Patch

Removing from review queue