After https://trac.webkit.org/changeset/156955/trunk/Tools/Scripts/run-javascriptcore-tests run-javascriptcore-tests runs LayoutTests/js tests only as part of run-jsc-stress-tests and after https://trac.webkit.org/changeset/157014/trunk/Tools/Scripts/run-javascriptcore-tests Mozilla tests and JSC stress tests are mutually exclusive. Accordingly the run-javascriptcore-tests result parser in master.cfg should be updated.
Created attachment 236763 [details] Proposed patch
Attachment 236763 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:122: [RunJavaScriptCoreTestsTest.test_no_failure_new_output] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:127: [RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:132: [RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output] Undefined variable 'FAILURE' [pylint/E0602] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236763 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=236763&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:122 > + self.assertResults(SUCCESS, ["jscore-test"], 0, """Results for JSC tests: typo: "Results for JSC stress tests:"
Comment on attachment 236763 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=236763&action=review r- for now, please fix the tests. > Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:133 > + self.assertResults(FAILURE, ["jscore-test", '1 failing JSC stress test '], 1, """Results for JSC stress tests: > + 1 failures found.""") http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29/builds/7128/steps/jscore-test/logs/stdio Results for JSC stress tests: 1 failure found. http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Traditional%20Linux%20Release%20%28Build%29/builds/6340/steps/jscore-test/logs/stdio Results for JSC stress tests: 7 failures found.
Created attachment 236767 [details] Patch
Attachment 236767 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:122: [RunJavaScriptCoreTestsTest.test_no_failure_new_output] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:127: [RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:132: [RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:137: [RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:141: [RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output] Undefined variable 'FAILURE' [pylint/E0602] [5] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236767 [details] Patch r=me
Comment on attachment 236767 [details] Patch Clearing flags on attachment: 236767 Committed r172748: <http://trac.webkit.org/changeset/172748>
All reviewed patches have been landed. Closing bug.