Bug 136019 - REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
Summary: REGRESSION (r168244): Content in horizontal-bt page is offset such that only ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-08-16 09:15 PDT by mitz
Modified: 2016-01-21 22:45 PST (History)
11 users (show)

See Also:

Attachments
Test case (589 bytes, text/html)
2014-08-16 09:15 PDT, mitz 		no flags Details
Patch (13.87 KB, patch)
2016-01-21 21:14 PST, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-08-16 09:15:02 PDT 
Created attachment 236717 [details]
Test case

To reproduce the bug, open the test case in Safari. The content is pushed down such that there is a white gap at the top and only the top (end) of the content is visible.
Comment 1 mitz 2014-08-16 09:15:34 PDT 
Caused by http://trac.webkit.org/r168244, the fix for bug 132535.
Comment 2 mitz 2014-08-16 09:17:19 PDT 
<rdar://problem/18040990>
Comment 3 Simon Fraser (smfr) 2016-01-03 11:11:24 PST 
Fixed, probably in https://trac.webkit.org/changeset/194487.
Comment 4 Simon Fraser (smfr) 2016-01-21 20:07:52 PST 
Not fixed.
Comment 5 Simon Fraser (smfr) 2016-01-21 20:09:06 PST 
The bug is that RLC sets the correct position of the root content layer at:
m_rootContentLayer->setPosition(FloatPoint(documentRect.x(), documentRect.y() + m_renderView.frameView().yPositionForRootContentLayer()));

but the scrolling thread overwrite that with a bad position at:
        m_scrolledContentsLayer.get().position = FloatPoint(m_scrolledContentsLayer.get().position.x,
            FrameView::yPositionForRootContentLayer(position, topContentInset, headerHeight()));

which ignores the documentRect part.
Comment 6 Simon Fraser (smfr) 2016-01-21 21:14:53 PST 
Created attachment 269547 [details]
Patch
Comment 7 Simon Fraser (smfr) 2016-01-21 22:45:47 PST 
https://trac.webkit.org/changeset/195445