WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136017
[GTK] build fails with error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’
https://bugs.webkit.org/show_bug.cgi?id=136017
Summary
[GTK] build fails with error: cannot allocate an object of abstract type ‘Web...
Byungseon(Sun) Shin
Reported
2014-08-16 03:01:28 PDT
./Tools/Scripts/build-webkit --gtk fails with this error: ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h: In static member function ‘static std::unique_ptr<WebKit::PageClientImpl> WebKit::PageClientImpl::create(GtkWidget*)’: ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:54:77: error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’ return std::unique_ptr<PageClientImpl>(new PageClientImpl(viewWidget)); ^ ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:46:7: note: because the following virtual functions are pure within ‘WebKit::PageClientImpl’: class PageClientImpl : public PageClient ^ In file included from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:33:0, from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:29: ../../Source/WebKit2/UIProcess/PageClient.h:306:18: note: virtual void WebKit::PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame() virtual void didFirstVisuallyNonEmptyLayoutForMainFrame() = 0; ^ ../../Source/WebKit2/UIProcess/PageClient.h:307:18: note: virtual void WebKit::PageClient::didFinishLoadForMainFrame() virtual void didFinishLoadForMainFrame() = 0; ^
Attachments
Patch
(2.21 KB, patch)
2014-08-16 03:06 PDT
,
Byungseon(Sun) Shin
no flags
Details
Formatted Diff
Diff
Patch
(2.21 KB, patch)
2014-08-16 03:07 PDT
,
Byungseon(Sun) Shin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Byungseon(Sun) Shin
Comment 1
2014-08-16 03:06:33 PDT
Created
attachment 236709
[details]
Patch
Byungseon(Sun) Shin
Comment 2
2014-08-16 03:07:59 PDT
Created
attachment 236710
[details]
Patch
WebKit Commit Bot
Comment 3
2014-08-16 03:08:17 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gyuyoung Kim
Comment 4
2014-08-16 06:53:12 PDT
Comment on
attachment 236710
[details]
Patch rs=me to fix build break on gtk port.
Gyuyoung Kim
Comment 5
2014-08-16 07:02:29 PDT
For the record,
r172635
caused this break.
http://trac.webkit.org/changeset/172635
.
WebKit Commit Bot
Comment 6
2014-08-16 07:26:30 PDT
Comment on
attachment 236710
[details]
Patch Clearing flags on attachment: 236710 Committed
r172690
: <
http://trac.webkit.org/changeset/172690
>
WebKit Commit Bot
Comment 7
2014-08-16 07:26:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug