Bug 136017 – [GTK] build fails with error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Byungseon(Sun) Shin]

./Tools/Scripts/build-webkit --gtk fails with this error:

../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h: In static member function ‘static std::unique_ptr<WebKit::PageClientImpl> WebKit::PageClientImpl::create(GtkWidget*)’:
../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:54:77: error: cannot allocate an object of abstract type ‘WebKit::PageClientImpl’
         return std::unique_ptr<PageClientImpl>(new PageClientImpl(viewWidget));
                                                                             ^
../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:46:7: note:   because the following virtual functions are pure within ‘WebKit::PageClientImpl’:
 class PageClientImpl : public PageClient
       ^
In file included from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:33:0,
                 from ../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:29:
../../Source/WebKit2/UIProcess/PageClient.h:306:18: note: 	virtual void WebKit::PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame()
     virtual void didFirstVisuallyNonEmptyLayoutForMainFrame() = 0;
                  ^
../../Source/WebKit2/UIProcess/PageClient.h:307:18: note: 	virtual void WebKit::PageClient::didFinishLoadForMainFrame()
     virtual void didFinishLoadForMainFrame() = 0;
                  ^

[Byungseon(Sun) Shin]

Created attachment 236709 [details]
Patch

[Byungseon(Sun) Shin]

Created attachment 236710 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gyuyoung Kim]

Comment on attachment 236710 [details]
Patch

rs=me to fix build break on gtk port.

[Gyuyoung Kim]

For the record, r172635 caused this break.

http://trac.webkit.org/changeset/172635.

[WebKit Commit Bot]

Comment on attachment 236710 [details]
Patch

Clearing flags on attachment: 236710

Committed r172690: <http://trac.webkit.org/changeset/172690>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.