Bug 136015 – Web Inspector: Improve performance of selection range changes viewing Scripts timeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Improve performance of selection range changes viewing Scripts timeline.

Whenever a selection range changes, we update all the nodes and mark them as needing a refresh. However, we only need to refresh an element if the new selection range changed the cross-section of that particular node. For example, if the selection range was showing the entire node, and is still showing the entire node, we don't need to refresh.

* STEPS TO REPRODUCE
1. Inspect iCloud.com
2. Show Timelines and Reload
3. Select Scripts timeline
4. Select a time range with a lot of scripts
5. Scrub / expand / collapse / change the time range selection
  => poor performance

* NOTES
We do still want to support "sub-event ranges". If there is a long script, you should be able to put a selection range for only part of that script evaluation and see only the Profile Nodes for that cross section.

[Radar WebKit Bug Importer]

<rdar://problem/18040028>

[Joseph Pecoraro]

Created attachment 236703 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 236703 [details]
[PATCH] Proposed Fix

Nice!

[WebKit Commit Bot]

Comment on attachment 236703 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236703

Committed r172689: <http://trac.webkit.org/changeset/172689>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.