Bug 136006 - Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
Summary: Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-15 16:28 PDT by Joseph Pecoraro
Modified: 2014-08-15 22:49 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (12.15 KB, patch)
2014-08-15 16:29 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (13.06 KB, patch)
2014-08-15 18:12 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-15 16:28:21 PDT 
* SUMMARY
Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator

* STEPS TO REPRODUCE
1. shell> ./Source/WebInspectorUI/Scripts/update-LegacyInspectorBackendCommands.rb
  => should work!
Comment 1 Radar WebKit Bug Importer 2014-08-15 16:28:32 PDT 
<rdar://problem/18037494>
Comment 2 Joseph Pecoraro 2014-08-15 16:29:57 PDT 
Created attachment 236689 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-08-15 16:36:13 PDT 
Comment on attachment 236689 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236689&action=review

> Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:76
> +InspectorBackend.registerEnum("Console.ConsoleMessageSource", {HTML: "html", Wml: "wml", XML: "xml", Javascript: "javascript", Network: "network", ConsoleAPI: "console-api", Other: "other"});

Should add WML to the generator.
Comment 4 Joseph Pecoraro 2014-08-15 17:10:45 PDT 
Err, or we should just remove it. We don't support it anymore right?
Comment 5 Joseph Pecoraro 2014-08-15 18:12:14 PDT 
Created attachment 236696 [details]
[PATCH] Proposed Fix
Comment 6 WebKit Commit Bot 2014-08-15 22:49:33 PDT 
Comment on attachment 236696 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236696

Committed r172688: <http://trac.webkit.org/changeset/172688>
Comment 7 WebKit Commit Bot 2014-08-15 22:49:35 PDT 
All reviewed patches have been landed.  Closing bug.