Bug 135991 - Fix plugin visibility check.
Summary: Fix plugin visibility check.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 12:49 PDT by Gavin Barraclough
Modified: 2014-08-15 14:22 PDT (History)
0 users

See Also:

Attachments
Fix (3.70 KB, patch)
2014-08-15 12:53 PDT, Gavin Barraclough 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-08-15 12:49:56 PDT 
We should only take a UserActivity if the plugin is in a visible window, and also is itself visible.
Comment 1 Gavin Barraclough 2014-08-15 12:53:38 PDT 
Created attachment 236671 [details]
Fix
Comment 2 Andreas Kling 2014-08-15 13:21:31 PDT 
Comment on attachment 236671 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236671&action=review

r=me

> Source/WebKit2/ChangeLog:20
> +            - added m_isVisibile, m_isWindowVisibile, updateVisiblityActivity.

m_isVisibile -> m_isVisible
m_isWindowVisibile -> m_isWindowVisible
updateVisiblityActivity -> updateVisibilityActivity
Comment 3 Gavin Barraclough 2014-08-15 13:32:36 PDT 
Transmitting file data ...
Committed revision 172645.
Comment 4 Gavin Barraclough 2014-08-15 13:37:48 PDT 
Type fix

Transmitting file data ...
Committed revision 172646.
Comment 5 Gavin Barraclough 2014-08-15 14:22:33 PDT 
Transmitting file data ...
Committed revision 172653.