Bug 135988 - Native library inlining crashes when module isn't found
Summary: Native library inlining crashes when module isn't found
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Mirman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 11:44 PDT by Matthew Mirman
Modified: 2014-08-15 14:04 PDT (History)
4 users (show)

See Also:

Attachments
fixed native library inlining in the ftl segfaulting (4.64 KB, patch)
2014-08-15 11:56 PDT, Matthew Mirman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2014-08-15 11:44:36 PDT 
Patch forthcoming.
Comment 1 Matthew Mirman 2014-08-15 11:56:39 PDT 
Created attachment 236663 [details]
fixed native library inlining in the ftl segfaulting

Also abstracts out an "Options::verboseCompilation"
Comment 2 Geoffrey Garen 2014-08-15 13:30:50 PDT 
Comment on attachment 236663 [details]
fixed native library inlining in the ftl segfaulting

View in context: https://bugs.webkit.org/attachment.cgi?id=236663&action=review

> Source/JavaScriptCore/ChangeLog:15
> +        (JSC::FTL::LowerDFGToLLVM::compilePutById): 
> +        abstracted out Options::verboseCompilation as was the case in the rest of the file.
> +        (JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
> +        (JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): 
> +        added output error messages for llvm module loading.

Best to capitalize these sentences.
Comment 3 WebKit Commit Bot 2014-08-15 14:04:48 PDT 
Comment on attachment 236663 [details]
fixed native library inlining in the ftl segfaulting

Clearing flags on attachment: 236663

Committed r172648: <http://trac.webkit.org/changeset/172648>
Comment 4 WebKit Commit Bot 2014-08-15 14:04:51 PDT 
All reviewed patches have been landed.  Closing bug.