Bug 135987 - de-PLATFORM(COCOA) a couple of methods in plugin code
Summary: de-PLATFORM(COCOA) a couple of methods in plugin code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 11:40 PDT by Gavin Barraclough
Modified: 2014-08-15 11:57 PDT (History)
0 users

See Also:

Attachments
Fix (13.20 KB, patch)
2014-08-15 11:48 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-08-15 11:40:45 PDT 
Pass through the visibility & focus on all platforms, to simplify & avoid any weird inconsistencies between platforms.
Comment 1 Gavin Barraclough 2014-08-15 11:48:12 PDT 
Created attachment 236662 [details]
Fix
Comment 2 Sam Weinig 2014-08-15 11:52:19 PDT 
Comment on attachment 236662 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236662&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:445
> +    m_plugin->windowVisibilityChanged(isVisible);

Add ASSERT to match?
Comment 3 Gavin Barraclough 2014-08-15 11:57:13 PDT 
Transmitting file data ............
Committed revision 172637.