Bug 135978 - Turn r/rx/ry to presentation attributes
Summary: Turn r/rx/ry to presentation attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 135045
  Show dependency tree / graph
 
Reported: 2014-08-15 09:29 PDT by Dirk Schulze
Modified: 2014-08-15 13:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (39.73 KB, patch)
2014-08-15 09:34 PDT, Dirk Schulze 		dino: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (794.42 KB, application/zip)
2014-08-15 11:34 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (935.98 KB, application/zip)
2014-08-15 12:36 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2014-08-15 09:29:12 PDT 
Turn r/rx/ry to presentation attributes
Comment 1 Dirk Schulze 2014-08-15 09:34:35 PDT 
Created attachment 236650 [details]
Patch
Comment 2 Dirk Schulze 2014-08-15 09:36:02 PDT 
The patch depends on bug 135975 and won't compile until the patch on the bug landed.
Comment 3 Build Bot 2014-08-15 11:34:47 PDT 
Created attachment 236660 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Dean Jackson 2014-08-15 11:45:41 PDT 
Comment on attachment 236650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236650&action=review

It seems this has much of the original cx/cy patch in it. Assuming that is removed when the cx/cy lands... r=me

> Source/WebCore/ChangeLog:64
> +2014-08-15  Dirk Schulze  <krit@webkit.org>
> +
> +        Turn cx/cy to presentation attributes
> +        https://bugs.webkit.org/show_bug.cgi?id=135975
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        This follows the patch for width and height presentation attributes and
> +        turns x and y to presentation attributes as well:
> +

ChangeLog has the previous patch in it as well.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:408
> +    CSSPropertyCx,
> +    CSSPropertyCy,

Oops.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2977
> +        case CSSPropertyCx:
> +            return zoomAdjustedPixelValueForLength(style->svgStyle().cx(), style.get());
> +        case CSSPropertyCy:
> +            return zoomAdjustedPixelValueForLength(style->svgStyle().cy(), style.get());

Oops.

> LayoutTests/ChangeLog:22
> +2014-08-15  Dirk Schulze  <krit@webkit.org>
> +
> +        Turn cx/cy to presentation attributes
> +        https://bugs.webkit.org/show_bug.cgi?id=135975
> +
> +        Reviewed by NOBODY (OOPS!).

More Oops.
Comment 5 Build Bot 2014-08-15 12:36:26 PDT 
Created attachment 236669 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Dirk Schulze 2014-08-15 12:43:00 PDT 
Committed r172642: <http://trac.webkit.org/changeset/172642>
Comment 7 Dirk Schulze 2014-08-15 13:49:01 PDT 
Committed r172647: <http://trac.webkit.org/changeset/172647>