The buildbot shows incorrect results on the performance bots if the run-perf-tests script returns with these special exit codes: 255, 254, 253, 252, 251 For example: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2887 The stdio says clearly what was the problem: Failed to upload JSON file to https://perf.webkit.org/api/report in 120s: program finished with exit code 252 But the buildbot handled this return code improperly: Failed 252 perf tests failed
Created attachment 236647 [details] Proposed patch
Attachment 236647 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:432: [RunAndUploadPerfTestsTest.assertResults] Undefined variable 'RunAndUploadPerfTests' [pylint/E0602] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236647 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=236647&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:729 > + if cmd.rc == 255: Can we use -1 & 0xff instead to match the code in perftestrunner.py?
Created attachment 236747 [details] Proposed patch
Created attachment 236748 [details] Proposed patch
Comment on attachment 236748 [details] Proposed patch Clearing flags on attachment: 236748 Committed r172701: <http://trac.webkit.org/changeset/172701>
All reviewed patches have been landed. Closing bug.