Bug 135968 - CSS JIT: compile :-webkit-full-page-media
Summary: CSS JIT: compile :-webkit-full-page-media
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 00:12 PDT by Benjamin Poulain
Modified: 2014-08-15 18:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2014-08-15 00:14 PDT, Benjamin Poulain 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-08-15 00:12:05 PDT 
CSS JIT: compile :-webkit-full-page-media
Comment 1 Benjamin Poulain 2014-08-15 00:14:34 PDT 
Created attachment 236644 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-08-15 10:07:55 PDT 
Comment on attachment 236644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236644&action=review

> Source/WebCore/ChangeLog:10
> +        It would be possible to inline it, but this selector is so unommon I don't think

Typo: should be "uncommon".

> Source/WebCore/css/SelectorCheckerTestFunctions.h:76
> +ALWAYS_INLINE bool isMediaDocument(const Element* element)

Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>.
Comment 3 Benjamin Poulain 2014-08-15 18:19:17 PDT 
Thanks for the review!

> > Source/WebCore/css/SelectorCheckerTestFunctions.h:76
> > +ALWAYS_INLINE bool isMediaDocument(const Element* element)
> 
> Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>.

The const has no value here, I'll remove it.
Comment 4 Benjamin Poulain 2014-08-15 18:37:51 PDT 
Committed r172663: <http://trac.webkit.org/changeset/172663>